Appbrowser segfaults on left column click before loading extensions list

[dmoerner]

This was originally reported by mikshaw in http://forum.tinycorelinux.net/index.php?topic=114.0 but I think it got lost in the shuffle.

I recompiled appbrowser, unstripped, from the source and got the following backtrace:

Code: [Select]

(gdb) run
Starting program: /home/tc/work/bugs/appbrowser/appbrowser
/mnt/hda2/tce/optional

Program received signal SIGSEGV, Segmentation fault.
0xb7d34b63 in strlen () from /lib/libc.so.6
(gdb) bt
#0  0xb7d34b63 in strlen () from /lib/libc.so.6
#1  0x080ad312 in std::string::operator= ()
#2  0x0804d4fe in brw_extn_callback () at appbrowser.cxx:67
#3  0x0804f6d5 in Fl_Widget::do_callback ()
#4  0x08052371 in Fl_Browser_::handle ()
#5  0x0804e17b in send ()
#6  0x0804eaac in Fl::handle ()
#7  0x08065df2 in fl_handle ()
#8  0x08065fa9 in do_queued_events ()
#9  0x0806627d in fl_wait ()
#10 0x0804f3a8 in Fl::wait ()
#11 0x0804f425 in Fl::run ()
#12 0x0804cfc8 in main (argc=1, argv=0xbfc25144) at appbrowser.cxx:172

However, why it's crashing is beyond my expertise--line 67 is the following.

Code: [Select]

select_extn = brw_extn->text(brw_extn->value());

[^thehatsrule^]

Thanks for the reminder... think this'll do the trick.  Submitted for next iteration.

If modifying the .cxx, insert a check into line 67

Code: [Select]

if (! brw_extn->value())
  return;

[roberts]

Squashed in rc3.