WelcomeWelcome | FAQFAQ | DownloadsDownloads | WikiWiki

Author Topic: Is this correct in /usr/bin/tce-setup?  (Read 2202 times)

Offline maro

  • Hero Member
  • *****
  • Posts: 1228
Is this correct in /usr/bin/tce-setup?
« on: February 28, 2010, 05:15:05 PM »
I was wondering if the tests in the following lines in 'usr/bin/tce-setup' (in TC 2.9rc5) are correct:

     93:  [ -n "$TCEDIR"/"$TARGETLIST" ] && for FILE in ....
    101:  [ -n "$TCEDIR"/"$TARGETLIST" ] && for FILE in ....


The '-n string' test will probably always be true, whilst I guess what is meant to be tested is with '-e file' the existance of the "onboot.lst" file. So, I believe it should be:

     93:  [ -e "$TCEDIR"/"$TARGETLIST" ] && for FILE in ....
    101:  [ -e "$TCEDIR"/"$TARGETLIST" ] && for FILE in ....

Offline roberts

  • Retired Admins
  • Hero Member
  • *****
  • Posts: 7361
  • Founder Emeritus
Re: Is this correct in /usr/bin/tce-setup?
« Reply #1 on: February 28, 2010, 05:29:30 PM »
Good find. Thanks. Fixed for 2.9 final.
10+ Years Contributing to Linux Open Source Projects.