intel-vaapi-driver broken in wayland

[GNUser]

Hi Juanito. You are the maintainer of intel-vaapi-driver.tcz. I think it needs a patch in order to work in wayland (e.g., labwc).

I'm on TCL16.2 x86_64. I have this at the very top of my onboot.lst:

Code: [Select]

libva22.tcz
intel-vaapi-driver.tcz
If I boot into X (fluxbox), all is well:

Code: [Select]

$ vainfo
Trying display: wayland
Trying display: x11
libva info: VA-API version 1.22.0
libva info: Trying to open /usr/local/lib/dri/iHD_drv_video.so
libva info: va_openDriver() returns -1
libva info: Trying to open /usr/local/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_1_22
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.22 (libva 2.22.0)
vainfo: Driver version: Intel i965 driver for Intel(R) Ivybridge Mobile - 2.4.1
vainfo: Supported profile and entrypoints
      VAProfileMPEG2Simple            : VAEntrypointVLD
      VAProfileMPEG2Simple            : VAEntrypointEncSlice
      VAProfileMPEG2Main              : VAEntrypointVLD
      VAProfileMPEG2Main              : VAEntrypointEncSlice
      VAProfileH264ConstrainedBaseline: VAEntrypointVLD
      VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice
      VAProfileH264Main               : VAEntrypointVLD
      VAProfileH264Main               : VAEntrypointEncSlice
      VAProfileH264High               : VAEntrypointVLD
      VAProfileH264High               : VAEntrypointEncSlice
      VAProfileH264StereoHigh         : VAEntrypointVLD
      VAProfileVC1Simple              : VAEntrypointVLD
      VAProfileVC1Main                : VAEntrypointVLD
      VAProfileVC1Advanced            : VAEntrypointVLD
      VAProfileNone                   : VAEntrypointVideoProc
      VAProfileJPEGBaseline           : VAEntrypointVLDBut if I boot into wayland (labwc)--same machine and same extensions loaded--I get this:

Code: [Select]

$ vainfo
Trying display: wayland
libva info: VA-API version 1.22.0
libva info: Trying to open /usr/local/lib/dri/iHD_drv_video.so
libva info: va_openDriver() returns -1
libva info: Trying to open /usr/local/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_1_22
error: failed to resolve wl_drm_interface(): /usr/local/lib/libEGL.so.1: undefined symbol: wl_drm_interface
libva error: /usr/local/lib/dri/i965_drv_video.so init failed
libva info: va_openDriver() returns -1
vaInitialize failed with error code -1 (unknown libva error),exit
Apparently libva 2.22.0 broke something and now this patch is needed for intel-vaapi-driver: https://github.com/intel/intel-vaapi-driver/pull/566

Would you be able to repackage intel-vaapi-driver.tcz with this patch?

[Juanito]

Sure, but it’ll have to wait until the weekend 🙂

[GNUser]

No worries. Thank you.

[GNUser]

Hi Juanito. I patched intel-vaapi-driver.tcz for testing and for my own use.

I can confirm that even though vainfo is still reporting an error in wayland environment, the expected "supported profile" and "entrypoints" are showing up now:

Code: [Select]

$ vainfo
Trying display: wayland
libva info: VA-API version 1.22.0
libva info: Trying to open /usr/local/lib/dri/iHD_drv_video.so
libva info: va_openDriver() returns -1
libva info: Trying to open /usr/local/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_1_22
error: failed to resolve wl_drm_interface(): /usr/local/lib/libEGL.so.1: undefined symbol: wl_drm_interface
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.22 (libva 2.22.0)
vainfo: Driver version: Intel i965 driver for Intel(R) Ivybridge Mobile - 2.4.1
vainfo: Supported profile and entrypoints
      VAProfileMPEG2Simple            : VAEntrypointVLD
      VAProfileMPEG2Simple            : VAEntrypointEncSlice
      VAProfileMPEG2Main              : VAEntrypointVLD
      VAProfileMPEG2Main              : VAEntrypointEncSlice
      VAProfileH264ConstrainedBaseline: VAEntrypointVLD
      VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice
      VAProfileH264Main               : VAEntrypointVLD
      VAProfileH264Main               : VAEntrypointEncSlice
      VAProfileH264High               : VAEntrypointVLD
      VAProfileH264High               : VAEntrypointEncSlice
      VAProfileH264StereoHigh         : VAEntrypointVLD
      VAProfileVC1Simple              : VAEntrypointVLD
      VAProfileVC1Main                : VAEntrypointVLD
      VAProfileVC1Advanced            : VAEntrypointVLD
      VAProfileNone                   : VAEntrypointVideoProc
      VAProfileJPEGBaseline           : VAEntrypointVLD

I can also confirm that applications can now use video acceleration. For example, mpv reports hardware decoding is being used (and it's telling the truth because  top  shows mpv using much less CPU than usual) when I run it like this:

Code: [Select]

$ mpv --vo=gpu --hwdec=vaapi some_movie_encoded_with_H264.mkv
Would you like me to make the necessary updates to metadata files and submit this patched intel-vaapi-driver.tcz for the x86_64 repo?

[Juanito]

Please go ahead

[GNUser]

Submitted.