Core v16.0beta1

[MikeLockmoore]

Hmm. I wasn't attempting to make something work for FLTK 1.3.  Some of the calls in my mods are FLTK 1.4.x specific.

I have a patch set for cleaning up some commented-out debugging statements, and a few text edits in comments.  i don't think there are any actual code changes in this patch set.

If you want me to look into the but graphic ("X" shape), I could try.  Was that at Xft.dpi set at 96.0 and no non-1.0 scaling set in an environment variable?  This patch is incremental to the one I posted yesterday.

 

[MikeLockmoore]

The patch I tried to attach to my last reply didn't.   

However, I've managed to better center the X on the window close button, and added some line weight to make the symbols on the buttons a bit easier to see and scale OK if you bumps up the scaling factor. So this patch includes both the code comment cleanups mentioned before as well as the better button symbols code update.  Only tested on TC 16 x86_64 (64 bit).

Note that this patch is incremental, mike_rescaling.patch should be applied first, then mike_rescaling_2.patch.

[curaga]

"git diff oldver..newver" will produce a combined patch.

[Juanito]

The first chunk of mike_rescaling.patch duplicates a commit I made yesterday - if I remove that (and several trailing white space errors) I get:

Code: [Select]

git apply ../mike_rescaling.patch
error: patch failed: Frame.C:1110
..which doesn't seem to make sense?

[MikeLockmoore]

The first chunk of mike_rescaling.patch duplicates a commit I made yesterday - if I remove that (and several trailing white space errors) I get:

Code: [Select]

git apply ../mike_rescaling.patch
error: patch failed: Frame.C:1110
..which doesn't seem to make sense?

Not sure about that, and I don't see anything crazy in the patch file around that line number that should lead to trouble (not sure exactly what is at that line number in the pre-patched file.  Is there a verbosity command line option with git apply *.patch to see more info about this?

If you still have trouble, maybe I can create a new single comprehensive patch to get to my code from the base version you would have straight from cloning the repo.  I need to get to my day job now, so I'll come back at this in 12 hours, give or take. 

[Juanito]

OK, got it  - the last two patches I used to build flwm are included in your changes, which creates the error as they are already in master.

[MikeLockmoore]

OK, got it  - the last two patches I used to build flwm are included in your changes, which creates the error as they are already in master.

Great!    I started with your build instructions which included at least one patch, and used that as the base of the patches I posted.

I'm not clear on the 32-bit x86 build issues.  Does FLTK 1.4.x not support 32-builds now?

[Juanito]

One of the main reasons to use fltk-1.4 is the wayland support, which means the tinycore fltk applets will work with a wayland compositor like labwc, weston, etc.

In order to reduce bloat, tinycore x86 does not use wayland. In addition fltk-1.4 is larger than fltk-1.3, so we decided to stay with fltk-1.3 for tc-16.x x86.

[Juanito]

Using git apply -R ../xxx.patch, I was able to back out the couple of patches I'd added and then apply mike_rescaling.patch and mike_rescaling_2.patch cleanly.

I've posted updated flwm/flwm_topside to the tc-16.x x86_64 repo.

Building flwm for tc-16.x x86 (fltk-1.3) fails with:

Code: [Select]

main.C: In function 'int main(int, char**)':
main.C:436:12: error: 'screen_scale' is not a member of 'Fl'
  436 |   sf = Fl::screen_scale(0);..which I guess is due to scaling not being supported on fltk-1.3

[Rich]

Hi Juanito
scale_factor was added in fltk-1.4.

[MikeLockmoore]

Hello testers... I've made many moderate changes to Fluff (file manager) and FLPicSee (image viewer) to work better with FLTK 1.4.  Would any of you like to test these new versions?  What's a good mechanism to do that these days?  -Mike

P.S. screenshot is set up a bit weird, but it's hard to keep the image file size within the 200K limit when showing much content on my 1920x1080 screen.

[Leee]

Hi MikeLockmoore.  I'd be happy to take a look at them.  I'm on x86_64, but could switch to 32 bit for this purpose if needed.
@Rich - is there a prescribed way to share new extensions for testing via the repo?

[Rich]

Hi MikeLockmoore

... P.S. screenshot is set up a bit weird, but it's hard to keep the image file size within the 200K limit when showing much content on my 1920x1080 screen.

The first thing I would do is convert from .png to .jpg:

Code: [Select]

tc@E310:~$ ls -l Downloads/screenshot_0315224859.png
-rw-r--r-- 1 tc staff 195902 Mar 16 06:51 Downloads/screenshot_0315224859.png
tc@E310:~$
tc@E310:~$ PicFormat -i Downloads/screenshot_0315224859.png -o Downloads/screenshot_0315224859.jpg
Input=Downloads/screenshot_0315224859.png  Fmt=png  W=1920  H=1080  AR=16:9
Output=Downloads/screenshot_0315224859.jpg  Fmt=jpg  W=1920  H=1080  AR=16:9  Rotate=0
tc@E310:~$
tc@E310:~$ ls -l Downloads/screenshot_0315224859.jpg
-rw-r--r-- 1 tc staff 172874 Mar 16 07:17 Downloads/screenshot_0315224859.jpg
A small reduction in image size yields a significant file size reduction.
Using a nice binary fraction like 7/8 (.875) reduces the image to 1680x945:

Code: [Select]

tc@E310:~$ PicFormat -i Downloads/screenshot_0315224859.png -o Downloads/screenshot_0315224859.jpg -w 1680
Input=Downloads/screenshot_0315224859.png  Fmt=png  W=1920  H=1080  AR=16:9
Output=Downloads/screenshot_0315224859.jpg  Fmt=jpg  W=1680  H=945  AR=16:9  Rotate=0
tc@E310:~$
tc@E310:~$ ls -l Downloads/screenshot_0315224859.jpg
-rw-r--r-- 1 tc staff 137362 Mar 16 07:26 Downloads/screenshot_0315224859.jpgTo my eyes, the reduced version looked just as good as your original.The text is
crisp, just slightly smaller (see attached image).

PicFormat is something I wrote a few years ago. It's 8k in size and depends on imlib2.tcz.
It's a simple command line program that does format conversion, rotation, size
conversion, and aspect ratio adjustment if desired.
Details of its used are included in the .info file:
http://tinycorelinux.net/16.x/x86/tcz/PicFormat.tcz.info
http://tinycorelinux.net/16.x/x86_64/tcz/PicFormat.tcz.info

[Rich]

Hi MikeLockmoore

Hello testers... I've made many moderate changes to Fluff (file manager) and FLPicSee (image viewer) to work better with FLTK 1.4.  Would any of you like to test these new versions?  What's a good mechanism to do that these days?  -Mike ...

If you like, I can setup a testing directory under http://tinycorelinux.net/16.x/x86_64/tcz/.
Email me a tarball (or 2) with the .tczs to test and I'll post them there.
I sent you an email so you'll have my address.
You might want to give the .tczs unique names so they don't clash
with official versions.