@Rich, yes - that's why I mentioned the "fix" as the reference stayed the same with or without it. This is mainly pointed out for future reference to EXISTING records (as it's HOPED that all of the upgrades done to SMF have corrected the reason the database records are broken in the first place.) If you come across an "Internal Error" you're likely looking for escapes from the already-saved-content which are completing a "broken loop." I'm reasonably certain it's caused by content already in the database record (ie: when you preview or save an update, you're asking SQL to
Update THIS to THAT where
THIS can be partially unescaped and still get by as PHP can make a few very basic assumptions, but
THAT just completely throws the system out of whack) where this record I'm typing right now can have the
exact same text and yet survive preview/save since there's no broken
THIS content:
In both files, update the change log to this:
Change-log: 2015/11/22 First version, 7.4.935
Current: 2020/09/23 update 7.4.935 -> $VERSION (matteo)
Replace $VERSION <-- Dollar $ign$ everywhere...
Back in the day (PHPv4'ish I think) we had to url_encode() everything like this if we wanted to save the content "as close to original" as possible yet allow it to be search-able by url_encoding the search string(s) along with it, and though it worked well, it wasn't perfect. I imagine SMF had similar issues once upon a time and our forum database is "that old" to have lapsed the years (and SMF revisions and PHP versions!)