gnome-mplayer Various Bugs

[SamK]

Hi AmatCoder,
Before getting into the bugs - thanks for this extension.  I missed it recently being added to the repo so did not test it until today.  I have been using  a similar private extension for the TC3 series and am very pleased to see you adding yours to the repo for the TC4 series.

Bugs

• Changes made using the interface in Edit-->Preferences-->tabs are not saved.  Closing and re-opening the app reverts to the pre-change state.
• In the Playlist window, there are two buttons without graphic icons
  
  • Loop Playlist
  • Shuffle Playlist
  The private extension used icons from  gnome-icon-themes (in the repo)
  
  • stock_repeat.png
  • stock_shuffle.png
• Changes made in Edit-->Preferences-->Interface are not actioned.  Perhaps this is a symptom of 1.  However, changing the Audio Output in Edit-->Preferences-->Player is implemented immediately.

Edit:  Corrected actioned to not actioned & spelling

[AmatCoder]

Hi SamK

1. My fault. libgmtk was compiled with dconf storage which tinycore lacks.

2. Yes, I do not usually include gnome-icon-theme as dependence because of size (>8M). I should have warned in info file.

3. Yes, this is related to 1.

I have recompiled libgmtk to avoid dconf storage, now it saves configuration under .config folder. I will send it.

Thanks for testing and apologies for inconveniences.

[Rich]

2. That's a pretty expensive dependency if you only need one or two icons.

[SamK]

2. Yes, I do not usually include gnome-icon-theme as dependence because of size (>8M). I should have warned in info file.

2. That's a pretty expensive dependency if you only need one or two icons.

I did not add gnome-icon-theme as a dependency as it is indeed quite large.  Instead I extracted the two previously named icons and added only those when building gnome-mplayer. 

There was also a third icon missing in my private extension which I never got around to fixing.  It is in the file drop-down menu.  It is also missing in the submitted extension.



Edit: Corrected present to missing