laptop-mode

[Roberto A. Foglietta]

in rcS (tc-config from v1.2) would be nice to have:

Code: [Select]

if [ -n "$LAPTOP" ]; then                                                      
   modprobe ac && modprobe battery
{       
   modprobe yenta_socket || modprobe i82365       
   /sbin/udevtrigger
   /etc/init.d/laptop-mode start
} >/dev/null 2>&1 &                                 
   echo " ${GREEN}Laptop options enabled (AC,Battery, & PCMCIA).${NORMAL}"
fi

instead of

Code: [Select]

if [ -n "$LAPTOP" ]; then                                                                           
   modprobe ac && modprobe battery                         
   modprobe yenta_socket >/dev/null 2>&1 || modprobe i82365 >/dev/null 2>&1
   /sbin/udevtrigger 2>/dev/null >/dev/null &                                                     
   echo " ${GREEN}Laptop options enabled (AC,Battery, & PCMCIA).${NORMAL}"                       
fi 


[curaga]

There's no such file as /etc/init.d/laptop-mode? Also, not all laptop users want it as a default..

[Roberto A. Foglietta]

There's no such file as /etc/init.d/laptop-mode? Also, not all laptop users want it as a default..

That file belong to cpufreq.tce/tcz. Those user which put option "laptop" into boot loader probably want something happens. If they do not want cpufreq/laptop-mode they should not install the related tce/tcz. As you can see the errors are redirected to dev null in such a way installing cpufreq is not necessary.

[roberts]

I am seeing many of your mods to system files that depend on extensions.
Yet you do not include a warning or statement of such.
Without this anyone who tries your mods will not have a good experience.

[Roberto A. Foglietta]

I am seeing many of your mods to system files that depend on extensions.
Yet you do not include a warning or statement of such.
Without this anyone who tries your mods will not have a good experience.

I will keep in mind your suggestion but in this case who install this mod and do not install cpufreq has the same experience of others who do not have installed any mods!

[curaga]

The errors should be directed away only from laptop-mode; if ac, battery, pcmcia fails, a laptop owner will want to know.

There's also the issue that extensions are loaded after that point, meaning an user couldn't get it to work without remastering.

[Roberto A. Foglietta]

The errors should be directed away only from laptop-mode; if ac, battery, pcmcia fails, a laptop owner will want to know.

Thanks for the suggestion I modified my original post.

There's also the issue that extensions are loaded after that point, meaning an user couldn't get it to work without remastering.

Infact the post was directed to developers in order to suggest them to adopt this mod directly into initrd image. Is there a better place to post this kind of suggestion?

[^thehatsrule^]

This would probably more suited for bootlocal.sh (or maybe an extension startup script)