Tiny Core Base > Release Candidate Testing

tinycore_v3.1rc4

<< < (3/4) > >>

ixbrian:
I'm trying to use ondemand with the firefox extension and it isn't working as expected.   

The on demand script that is created by /usr/bin/ondemand is this:


--- Code: ---#!/bin/sh
2>/dev/null read TCEDIR < /opt/.tce_dir || exit 1
if [ ! -e /usr/local/tce.installed/firefox ]; then
  tce-load -is $TCEDIR/optional/firefox.tcz
fi
[ $(which /usr/local/firefox) ] && exec /usr/local/firefox-official/firefox

--- End code ---

The extension is being mounted, however it doesn't start firefox because of the "which /usr/local/firefox" on the last line which returns false. 

   Line 75 in ondemand is:  echo '[ $(which '"${BINARY%%-*}"') ] && 'exec "$BINARY" >> "$FILE",  so it looks like the "${BINARY%%-*}" part is stripping off everything after the "-" in the path to firefox. 

roberts:
Yeah, that is why I use "_" and not "-"
As "-"  to me indicates flag options of which there are many, e.g., Opera extension.

However, good find. I will address before final. Thanks.

roberts:
Adding a space before the "-" the string chopping fixes the dash in BINARYbug.
Done.

Jason W:
Would it help if we used the underscore in extension names instead of dash?

roberts:
Not necessary, it was my bad.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version