WelcomeWelcome | FAQFAQ | DownloadsDownloads | WikiWiki

Author Topic: TCL-14.0 submitqc doesnt honor --no-fix  (Read 389 times)

Offline rhermsen

  • Jr. Member
  • **
  • Posts: 90
TCL-14.0 submitqc doesnt honor --no-fix
« on: February 07, 2024, 08:05:05 AM »
submitqc seems to ignore the --no-fix option.


I used the command:
Code: [Select]
$ sudo submitqc --no-fix --libs
In the output I see that some permissions are found incorrect.
It is good that is notifies these 'inconsistencies' but they should not be fixed.
(the file init-functions should indeed be 755 i.s.o. 644)

Code: [Select]
$ cat /tmp/submitqc/fileperms
frr.tcz: Some directory or file permissions were incorrect or non-standard.
Directories - Expected root:root:
./usr/local/etc/frr

Files - Expected root:root:
./usr/local/etc/frr/daemons.sample

Files - Expected 755:
./usr/local/lib/frr/init-functions

frr.tcz: These errors were corrected.


On a second run it gives:
Code: [Select]
submitqc: frr.tcz: setting ownership & permissions of frr.tcz* ... Ok!


Code: [Select]
$ version
14.0

$ uname -m
i686

Possible related threads:
https://forum.tinycorelinux.net/index.php/topic,26381.msg170220.html
https://forum.tinycorelinux.net/index.php/topic,26146.msg167989.html
https://forum.tinycorelinux.net/index.php/topic,24459.msg155078.html
« Last Edit: February 07, 2024, 08:33:25 AM by rhermsen »

Offline polikuo

  • Hero Member
  • *****
  • Posts: 714
Re: TCL-14.0 submitqc doesnt honor --no-fix
« Reply #1 on: February 12, 2024, 05:10:49 AM »
Hi, rhermsen

If I read it correctly, you're saying that the permissions of the files are corrected even if you tell it not to.

I can probably have a look at it in a few days.

Could you provide more details so I can test it before submission ?

P.S.
Quote
Code: [Select]
$ sudo submitqc --no-fix --libs
You shouldn't use "sudo" for that.
« Last Edit: February 12, 2024, 05:15:10 AM by polikuo »

Offline GNUser

  • Hero Member
  • *****
  • Posts: 1333
Re: TCL-14.0 submitqc doesnt honor --no-fix
« Reply #2 on: February 12, 2024, 10:02:25 AM »
Hi rhermsen. Thanks for reporting this.

Hi polikuo. Culprit is this part of submitqc, which appears after command line options have been parsed:
Code: [Select]
# other global variables
FIXFILES=1
I'll repair this. Right now the fix/don't fix logic is a bit convoluted and needs some cleanup, anyway.

Offline rhermsen

  • Jr. Member
  • **
  • Posts: 90
Re: TCL-14.0 submitqc doesnt honor --no-fix
« Reply #3 on: February 12, 2024, 11:12:20 AM »
Hi @GNUser, @polikuo,

Thanks both for looking into this!


I will look if I can omit sudo for this command.

Offline GNUser

  • Hero Member
  • *****
  • Posts: 1333
Re: TCL-14.0 submitqc doesnt honor --no-fix
« Reply #4 on: February 12, 2024, 11:49:44 AM »
Hi rhermsen. Glad I could help. I submitted an updated submitqc extension for the TCL14 repos. It should appear in the repo soon. It will honor the --no-fix flag.

And polikuo is right regarding sudo. You should run submitqc as regular user.