WelcomeWelcome | FAQFAQ | DownloadsDownloads | WikiWiki

Author Topic: [Solved]: patch for submitqc.tcz  (Read 3362 times)

Online Rich

  • Administrator
  • Hero Member
  • *****
  • Posts: 11138
Re: [Solved]: patch for submitqc.tcz
« Reply #30 on: March 09, 2023, 06:50:15 AM »
Hi GNUser
TC14 x86 and x86_64 repos have been updated.

If anyone installed submit.tcz since reply #26, please update your copy for a bug fix.

Offline GNUser

  • Hero Member
  • *****
  • Posts: 1328
Re: [Solved]: patch for submitqc.tcz
« Reply #31 on: March 09, 2023, 06:58:04 AM »
Hi Rich. I updated submitqc.tcz on my TC14 x86_64. Works like a dream now.

IMHO now submitqc does everything an extension submitter assumes it is doing. This includes ensuring that ownership and permissions of key files/directories conform to what is recommended in the wiki.

Happy hacking :)

aus9

  • Guest
Re: [Solved]: patch for submitqc.tcz
« Reply #32 on: March 09, 2023, 04:31:21 PM »
hi GNUser

thanks for submitqc, I rely on it fix a lot of my mistakes.

umm because I have AMD APU and unable to boot into xbase.lst I found a command on the web you might consider adding for dep suggestions to submitter?

Code: [Select]
tce-load -i binutils
readelf -d /pathway2/executable | grep 'NEEDED'

I then use Apps provides to see what TCE contains needed
I then use a local searchtce script to see if I can shorten my dep list.

here is example for you of extra TCE research
0x0000000000000001 (NEEDED) Shared library: [libfontconfig.so.1]  # fontconfig  -> libXft
so I used apps to get TCE name......and found it is a dep of libXft

Naturally it works on shared object files and I know others tend to use ldd

Offline GNUser

  • Hero Member
  • *****
  • Posts: 1328
Re: [Solved]: patch for submitqc.tcz
« Reply #33 on: March 10, 2023, 05:35:50 AM »
Hi aus9. My workflow for building .dep files is the same as yours. I use readelf -d as well.

Rich has created a script that may do what you are asking for. I haven't tested it yet but like the idea:

http://forum.tinycorelinux.net/index.php/topic,26040.0.html

aus9

  • Guest
Re: [Solved]: patch for submitqc.tcz
« Reply #34 on: March 10, 2023, 11:45:22 PM »
thanks I have bookmarked Rich's script. 

aus9

  • Guest
Re: [Solved]: patch for submitqc.tcz
« Reply #35 on: March 12, 2023, 11:11:29 PM »
hi GNUser

forgive me for following feedback....ignore the fact that my build no longer needs some packages and
because its a GUI, I have added an icon theme for a tce.install script to update icon cache.

When you get a chance....can you stop a report of a dep with both a negative and  + entry
see imlib2 as reported as missing and then it find it is not missing....in submitqc under "missingdeps" report

Quote
--- /tmp/submitqc/missingdeps/feh.tcz.dep.remote   2021-12-26 13:10:10.000000000 +0000
+++ ./feh.tcz.dep   2023-03-13 06:00:34.550051675 +0000
@@ -1,7 +1,8 @@
-imlib2.tcz
-libexif.tcz
-libXinerama.tcz
 curl.tcz
-libjpeg-turbo-bin.tcz
-jpegexiforient.tcz
-gtk2.tcz
+file.tcz
+libXinerama.tcz
+libexif.tcz
+libpng.tcz
+libX11.tcz
+imlib2.tcz
+hicolor-icon-theme.tcz

let me know your thoughts when you get a chance please

Offline GNUser

  • Hero Member
  • *****
  • Posts: 1328
Re: [Solved]: patch for submitqc.tcz
« Reply #36 on: March 13, 2023, 06:47:32 AM »
Hi aus9. I briefly looked into your issue.

First I did some sanity checks:
- feh is dynamically linked to libImlib2.so.1, which is provided by imlib2.tcz
- none of feh's other dependencies bring in imlib2.tcz, so imlib2.tcz does need to be present in feh.tcz.dep
- feh.tcz.dep includes imlib2.tcz, so we're good

I ran submitqc --libs on feh.tcz and am not seeing any conflicting information about imlib2.tcz.

Honestly, I don't use submitqc to help me build .dep files (I use readelf + provides.sh + deptree) so I'm not too familiar with what submitqc does in this regard. But I can tell you that If you did find a bug in submitqc, it is not related to the patches I've submitted recently, which deal only with setting correct ownerships/permissions in the squashfs.

I don't have time to look into this further right now, unfortunately.

    [Edit]: Changed imlib,tcz to imlib2.tcz.  Rich
« Last Edit: March 13, 2023, 09:54:20 AM by Rich »

Offline GNUser

  • Hero Member
  • *****
  • Posts: 1328
Re: [Solved]: patch for submitqc.tcz
« Reply #37 on: March 13, 2023, 08:20:43 AM »
Oops. Everywhere I wrote imlib.tcz I meant imlib2.tcz.

Online Rich

  • Administrator
  • Hero Member
  • *****
  • Posts: 11138
Re: [Solved]: patch for submitqc.tcz
« Reply #38 on: March 13, 2023, 09:54:42 AM »
Hi GNUser
Fixed.

Online Rich

  • Administrator
  • Hero Member
  • *****
  • Posts: 11138
Re: [Solved]: patch for submitqc.tcz
« Reply #39 on: March 13, 2023, 10:22:59 AM »
Hi aus9
... When you get a chance....can you stop a report of a dep with both a negative and  + entry
see imlib2 as reported as missing and then it find it is not missing....in submitqc under "missingdeps" report ...
It's running a diff between your  .dep  file and the current  .dep  file in the repo.

Place the common dependencies in the same order at the beginning of your file
as the ones in the repo  .dep  file like this:
Code: [Select]
imlib2.tcz
libexif.tcz
libXinerama.tcz
curl.tcz
file.tcz
libpng.tcz
libX11.tcz
hicolor-icon-theme.tcz
and you won't see that behavour.

By the way, you don't need to include  libpng.tcz  and  libX11.tcz.  They get pulled
in by  imlib2.tcz:
Code: [Select]
rich@tcbox:~$ cat imlib2.tcz.tree
imlib2.tcz
   freetype.tcz
      libpng.tcz
      harfbuzz.tcz
         glib2.tcz
            libffi.tcz
            pcre.tcz
         graphite.tcz
      bzip2-lib.tcz
   libjpeg-turbo.tcz
   libpng.tcz <-------------
   libXext.tcz
      libX11.tcz <----------
         libxcb.tcz
            libXau.tcz
            libXdmcp.tcz

aus9

  • Guest
Re: [Solved]: patch for submitqc.tcz
« Reply #40 on: March 14, 2023, 12:09:51 AM »
GNUser

no worries my fault in not spotting layout is same as a diff command. I blame me for not being a real coder  :-[

Hi Rich
sorry for the noise