WelcomeWelcome | FAQFAQ | DownloadsDownloads | WikiWiki

Author Topic: Very well, closing this. your patch is wrong (on /usr/sbin/rebuildfstab)  (Read 2588 times)

Offline CNK

  • Full Member
  • ***
  • Posts: 248
Re: Very well, closing this. your patch is wrong (on /usr/sbin/rebuildfstab)
« Reply #15 on: February 19, 2023, 03:50:43 PM »
I thought that comments were another thing where there was a balance with keeping things tiny. More text equals larger script files, which overall might be significant. A very well commented script might be twice the size of a sparsely commented one, or more, and uncomressed text isn't all the small, so I assume the TC developers want to strike a balance.

Anyway when this was first posted I took a look and was able to spot some optimisations in the script that were possible with much less significant changes to how the script operates.

Code: [Select]
# echo modified: ;time rebuildfstab-mod; echo original: ; time rebuildfstab
modified:
real    0m 0.40s
user    0m 0.07s
sys     0m 0.21s
original:
real    0m 0.63s
user    0m 0.23s
sys     0m 0.38s

But I haven't got around to testing that it really works the same in lots of different circumstances yet.