[Solved] links in ~/.X.d/ don't work, a small change to Xlibs.tcz fixes it

[Rich]

Hi jazzbiker

@Rich
 ... what's Your opinion about these sort's in .xsession? Probably andyj is using persistent ~ too.

I'm a big fan of consistent behavior, so my opinion is include the sort command.

[jazzbiker]

Using ls for creation time based sorting:

Code: [Select]

[ -d "/usr/local/etc/X.d" ] && ls -tc $(find "/usr/local/etc/X.d" -type f -o -type l) | while read F; do echo "$F"; done


[GNUser]

GNUser, sorry for disturbing and making so many noise.

It's an interesting discussion, not noise, so nothing to be sorry about

My two cents on the thread so far:

1. I love how conservative TCL is, and how much care goes into making sure that changes cause no breakage. This is yet another of TCL's many outstanding qualities.

2. I agree that predictability and controllability are both important. It seems that having "sort" in the /usr/local/etc/X.d line would add predictability and, for extensions where it is important, would give the extension maintainer controllability. TCL11 x86_64 repo currently has only one extension (open-vm-tools-desktop.tcz) that puts something in /usr/local/etc/X.d, so it would not be difficult for extension maintainers to coordinate in the unlikely event that execution order matters.

[Rich]

Hi jazzbiker
Changing file names to control order of execution is more practical and intuitive than changing creation times.

[Juanito]

I haven't updated Xlibs so far as it looks like we didn't come to an agreement on changes to the start-up script?

[jazzbiker]

Hi, Juanito!

I feel guilty, that my attempt to propose sorting improvement leads to GNUser's proposal refusal. In my opinion we all agreed that adding "sort" to both ~/X.d and /usr/local/etc/X.d chains will provide predictability and controlability - this is GNUser's second submitted extension. If You expect this controversial, please post the first GNUser's submission with links added to ~/.X.d chain and without any sortings.

[GNUser]

My impression was that we had reached agreement. To summarize:

1. Supporting links in $HOME/.X.d is an add-on feature that does not break anything; curaga gave the green light and there were no objections.

2. Adding  sort  to the $HOME/.X.d line would ensure predictable execution order of user's jobs; any breakage that arises from the change (going from unpredictable to predictable execution order) would be easy to fix by user renaming jobs so that names reflect desired execution order.

3. Adding  sort  to the  /usr/local/etc/X.d  line shouldn't break anything because it seems only rare extensions (I can only find open-vm-tools-desktop.tcz) use that directory. It seems advantageous to have  sort  in there going forward, to ensure predictability if/when more extensions use that directory.

Objectors and supporters, please speak up! If no objections are voiced, perhaps it would be reasonable to assume agreement and move forward with the changes.

P.S. My second Xlibs.tcz submission is the one that contains all of the proposed changes.

[Juanito]

To avoid confusion, please post the startup script here.

[Rich]

Hi GNUser

My impression was that we had reached agreement. To summarize: ...

1. Agreed.

2. Agreed. It also removes the unpredictability between RAM and hard drive behavior mentioned here:
http://forum.tinycorelinux.net/index.php/topic,24585.msg156066.html#msg156066

3. Agreed. Since andyj approves, that's good enough for me.

[GNUser]

Hi, Juanito. Here is /etc/skel/.xsession (part of Xlibs.tcz) with all three proposed changes:

Code: [Select]

Xvesa -br -screen 1024x768x32 -shadow -2button -mouse /dev/input/mice,5 -nolisten tcp -I >/dev/null 2>&1 &
export XPID=$!
waitforX || ! echo failed in waitforX || exit
"$DESKTOP" 2>/tmp/wm_errors &
export WM_PID=$!
[ -x $HOME/.setbackground ] && $HOME/.setbackground
[ -x $HOME/.mouse_config ] && $HOME/.mouse_config &
[ $(which "$ICONS".sh) ] && ${ICONS}.sh &
[ -d "/usr/local/etc/X.d" ] && find "/usr/local/etc/X.d" -type f -o -type l | sort | while read F; do . "$F"; done
[ -d "$HOME/.X.d" ] && find "$HOME/.X.d" -type f -o -type l | sort | while read F; do . "$F"; done

[andyj]

3. Agreed. Since andyj approves, that's good enough for me.

[jazzbiker]

To close any doubts in the full consensus, my answers to GNUser's questions put in the #36 post are:

1. Yes (links in ~/.X.d)
2. Yes (find $HOME/.X.d | sort)
3. Yes (find /usr/local/etc/X.d | sort)

[Juanito]

Xlibs updated in 11.x x86/x86_64 repos and 12.x armv6/armv7/aarch64 repos

[GNUser]

Hurray!
Thank you all for the interesting discussion and Juanito for posting