Tiny Core Base > TCB Bugs

mnttool: notice on failed umount, sync w/ cli umount?

(1/3) > >>

dentonlt:
This is probably a curaga type question:

Continuing on the mnttool edits ...

Currently there is no warning/notice when mnttool fails to umount. mnttool just continues to display green (mounted). I'd be interested in a brief popup that either says "I can't umount this" or even better "foo and faw have this mount point open." I'm happy to add that code - it should be straightforward to handle the failed system("umount foo") call.

Second, mnttool seems to get out of sync with /mnt/ if the user calls umount or mount via the CLI. Some mount points are displayed green/red when they're not ... or just altogether don't exit. I'm happy to investigate and put in a patch myself.

Main concern is whether the team considers these adding cruft! Else I'll get to it.

Rich:
Hi dentonlt

--- Quote ---Currently there is no warning/notice when mnttool fails to umount. mnttool just continues to display green (mounted).
--- End quote ---
The fact that it stays green is your warning.

--- Quote ---Second, mnttool seems to get out of sync with /mnt/ if the user calls umount or mount via the CLI.
--- End quote ---
Well sure, you're changing mounted items behind  mnttools  back. Clicking the  Refresh  button should bring it back in sync.

curaga:
Yeah, changing behind its back is not supposed to work really. A popup for failure would be welcome.

nitram:
Haven't looked at mnttool and not an experienced coder, just my thoughts. For me popups not appreciated. What about incorporating an idle time out every 10-15 seconds that auto-refreshes mounts when mnttool open. If mismatch between colour indicator and mount results, indicator flashes red/green [edit] or turns yellow [/edit] to notify user of a problem. Cherry on top would be to check if  ntfs-3g  is loaded prior to mounting NTFS partitions, then mount them with  ntfs-3g  command so they are read/write not just read-only. Thanks for your work dentonlt.

dentonlt:

--- Quote ---The fact that it stays green is your warning.

--- End quote ---

Ha! I'm surprised I hadn't thought of it that way ... You're right, of course.


--- Quote ---Yeah, changing behind its back is not supposed to work really.
--- End quote ---

Maybe that's the main problem I should address. Or at least first.


--- Quote ---Cherry on top would be to check if  ntfs-3g  is loaded prior to mounting NTFS partitions, then mount them with  ntfs-3g  command so they are read/write not just read-only.
--- End quote ---

That's a novel idea. I guess the main question is whether that's suitable to include that sort of code inside of stock/base TC? I don't know if we have other tools/areas that add/extend features dependent upon the presence of optional binaries ... ? At face value, that sounds good to me.

Navigation

[0] Message Index

[#] Next page