WelcomeWelcome | FAQFAQ | DownloadsDownloads | WikiWiki

Author Topic: submitqc: issue with dependency check  (Read 355 times)

Online Rich

  • TinyCore Moderator
  • Hero Member
  • *****
  • Posts: 6844
submitqc: issue with dependency check
« on: July 18, 2019, 01:41:33 PM »
When  submitqc  compares a  .dep  file to an existing  .dep  file in the repo, it flags them as different if they have the same
contents but in a different order.

Cosmetic:
Line 905:
Code: [Select]
echo -ne "\n\t${YELLOW}${F}.tcz.list does not match extension content. \The  ${F}  already contains  .tcz,  so  ${F}.tcz.list  expands to  NAME.tcz.tcz.list.

Offline coreplayer2

  • Hero Member
  • *****
  • Posts: 3020
submitqc: issue with dependency check
« Reply #1 on: July 18, 2019, 06:53:21 PM »
Hello Rich

Interesting thanks
I’m not sure I remember how the contents were tested but an alternative approach perhaps would be to sort contents of both before testing ?

Will take a look at the issue



Sent from my iPhone using Tapatalk

Online Rich

  • TinyCore Moderator
  • Hero Member
  • *****
  • Posts: 6844
Re: submitqc: issue with dependency check
« Reply #2 on: July 18, 2019, 07:15:11 PM »
Hi coreplayer2
Sorting would be the most straightforward way of doing it.. I was rather surprised to be informed my  .dep  file with 2 entries
didn't match the repo.

Offline coreplayer2

  • Hero Member
  • *****
  • Posts: 3020
submitqc: issue with dependency check
« Reply #3 on: July 18, 2019, 09:47:50 PM »
Hello Rich.

I wonder how this was discovered,  the —fix switch resolved most issues I just don’t remember if that specific issue is normally fixed or is just a notification, considering the author might require deps to be loaded in a specific order.



Sent from my iPhone using Tapatalk
« Last Edit: July 18, 2019, 09:49:45 PM by coreplayer2 »

Online Rich

  • TinyCore Moderator
  • Hero Member
  • *****
  • Posts: 6844
Re: submitqc: issue with dependency check
« Reply #4 on: July 18, 2019, 10:09:47 PM »
Hi coreplayer2
It's a notification. Dependencies change so you can't fix them based on previous versions of an extension.