Tiny Core Extensions > TCE Bugs

Possible bug for 64 bit submitqc for tce.installed issue

(1/4) > >>

aus9:
Possible bug for checking of tce.installed using 64 bit submitqc

First my submitqc has md5sum
7b157080f71142c84a5faf2cc66b3308  submitqc.tcz

I do not care about all tests, as submitqc seems to cause no problems for them
so if you have time, can someone on 64 bit either confirm or deny the following test.

I create a tcz using root powers
get submitqc to check it
post a snippet of correction it does
unpack the TCZ and show what has occurred ....YMMV

copy and paste from quote box into your favourite terminal please after becoming root by

--- Code: ---sudo su
--- End code ---


--- Quote ---# test we are root
if [ "$(id -u)" != "0" ]; then
   echo "run as root now exitting"
   exit 1
fi

USER=`cat /etc/sysconfig/tcuser`
su -c "tce-load -i submitqc" $USER
cd /tmp
mkdir -p test/usr/local/tce.installed
touch test/usr/local/tce.installed/test
# ^^ normal executable was also checked but this is shorter
chmod 775 -R test/usr/local/tce.installed
chown root:staff -R test/usr/local/tce.installed
mksquashfs test test.tcz
submitqc --fix

--- End quote ---

Please ignore the warning I have not made an info file or md5 or dep

What you might see if bug is there?


--- Code: ---tc@box:~$ sudo su
root@box:/home/tc# if [ "$(id -u)" != "0" ]; then
>    echo "run as root now exitting"
>    exit 1
> fi
root@box:/home/tc#
root@box:/home/tc# USER=`cat /etc/sysconfig/tcuser`
root@box:/home/tc# su -c "tce-load -i submitqc" $USER
zsync.tcz: OK
libzstd.tcz: OK
lzo.tcz: OK
squashfs-tools.tcz: OK
binutils.tcz: OK
grep.tcz: OK
libcap.tcz: OK
coreutils.tcz: OK
nettle.tcz: OK
gnutls.tcz: OK
wget.tcz: OK
diffutils.tcz: OK
file.tcz: OK
submitqc.tcz: OK
root@box:/home/tc# cd /tmp
root@box:/tmp# mkdir -p test/usr/local/tce.installed
root@box:/tmp# touch test/usr/local/tce.installed/test
root@box:/tmp# # ^^ normal executable was also checked but this is shorter
root@box:/tmp# chmod 775 -R test/usr/local/tce.installed
root@box:/tmp# chown root:staff test/usr/local/tce.installed
root@box:/tmp# mksquashfs test test.tcz
Parallel mksquashfs: Using 4 processors
Creating 4.0 filesystem on test.tcz, block size 4096.


Exportable Squashfs 4.0 filesystem, gzip compressed, data block size 4096
compressed data, compressed metadata, compressed fragments, no xattrs
duplicates are removed
Filesystem size 0.29 Kbytes (0.00 Mbytes)
69.93% of uncompressed filesystem size (0.42 Kbytes)
Inode table size 80 bytes (0.08 Kbytes)
49.38% of uncompressed inode table size (162 bytes)
Directory table size 76 bytes (0.07 Kbytes)
71.03% of uncompressed directory table size (107 bytes)
Number of duplicate files found 1
Number of inodes 5
Number of files 1
Number of fragments 0
Number of symbolic links  0
Number of device nodes 0
Number of fifo nodes 0
Number of socket nodes 0
Number of directories 4
Number of ids (unique uids + gids) 2
Number of uids 1
root (0)
Number of gids 2
root (0)
staff (50)
root@box:/tmp# submitqc --fix

==============================================================
This is the Tiny Core extension submission quality testing tool.
This pre-release is UNDER TESTING for TC5/6 and x86/x86_64.

see --help for usage instructions.

Release: SOURCE RUN
==============================================================

Checking against Core release 9.x on x86_64 / 4.14.10-tinycore64

submitqc: loading required extensions ... Done.
submitqc: removing old log files. Ok.
submitqc: making space for new log files. Done.
submitqc: checking http://repo.tinycorelinux.net/ (timeout 3 sec) ... Connected!
submitqc: fetching info.lst.gz ... Ok.

submitqc: test.tcz checks begin =====
submitqc: test.tcz squashfs tree has files in it? Ok.
submitqc: test.tcz info file structure ok?
test.tcz.info file not found. Do NOT submit without it.
submitqc: test.tcz info similar to others in repository?
There are similar named extensions in repo:
firefox_getLatest
googletest-dev
googletest
mariadb-10.1-test
Ensure there are no conflicts between test.tcz and other extensions.
submitqc: test.tcz dep file compared to repository copy? No dep file in repo - done.
submitqc: test.tcz dependencies exist? No dep file. Ok.
submitqc: test.tcz mountable? Passed mount check.
submitqc: test.tcz correct block size? Yes.
submitqc: test.tcz unsquashing for further tests ... Done.
submitqc: test.tcz squashfs tree ok? Ok.
submitqc: test.tcz startup files ok?
Startup script permissions were corrected.
Startup script ownership was corrected.
submitqc: test.tcz includes copyright notice?
Copyright notice not found at usr/local/share/doc/test
Confirm that this is not needed.
Checking repo for copyright statement in test.tcz ...
test.tcz not found on server.
submitqc: test.tcz file/directory ownerships & permissions ok? Ok.
submitqc: test.tcz binaries have been stripped? Ok.
submitqc: test.tcz list file looks ok?
test.tcz.list missing. Creating ... Done.
submitqc: test.tcz comparing list to mirror copy. Not on mirror.
submitqc: test.tcz to enable library inclusion tests, use --libs.
Without lib tests, check is considered incomplete.
submitqc: make squashfs with changes ... Done. test.tcz + test.tcz.md5.txt updated.
submitqc: test.tcz checking md5.txt. Ok.
submitqc: test.tcz squash tree checks complete. Cleaning up ... Done.
submitqc: test.tcz creating new test.tcz.zsync Done.
submitqc: test.tcz.build-dep or build-dep included?
Not found, but it is suggested/requested.
submitqc: test.tcz.tgz included?
Not found, but it is suggested/requested.
submitqc: test.tcz: setting ownership & permissions of test.tcz* ... Ok!
submitqc: test.tcz checks end =====


submitqc: There are warnings or errors for your extensions. See:
/tmp/submitqc/copyright
/tmp/submitqc/missingdeps/test.tcz.dep-libs
/tmp/submitqc/noinfofile
/tmp/submitqc/similarextensions
/tmp/submitqc/wrongstartscriptperms
Some errors may have been corrected - see logs and above.
Fix errors and run submitqc again before submitting.
Log files will be destroyed the next time submitqc is run.
Without warnings or errors, this message will go away.
--- End code ---

Let me repeat the bits that concerns me please

--- Code: ---Startup script permissions were corrected.
Startup script ownership was corrected.
/tmp/submitqc/wrongstartscriptperms
--- End code ---

Now lets check what it did to me
copy and paste from quote box please


--- Quote ---unsquashfs test.tcz
ls -al squashfs-root/usr/local/tce.installed/
--- End quote ---

What I get

--- Code: ---unsquashfs test.tcz
Parallel unsquashfs: Using 4 processors
1 inodes (0 blocks) to write



created 1 files
created 4 directories
created 0 symlinks
created 0 devices
created 0 fifos
root@box:/tmp# ls -al squashfs-root/usr/local/tce.installed/
total 0
drwxrwxr-x 2 root staff 60 Aug  8 14:06 .
drwxr-xr-x 3 root root  60 Aug  8 14:06 ..
-rwxr-xr-x 1 tc   staff  0 Aug  8 14:06 test
--- End code ---

according to the wiki and the forum post for submissions.....that dir and script  is supposed to be
root:staff
775

thanks for reading

I sent a pm to the current maintainer  dentonlt but he has not been active for a long time
and its been more than one week since pm sent

IMHO the dir is fine but the script is wrong?

aus9:
I forgot to paste the -R results above but they are the same as without the -R.

quote box is still good.

coreplayer2:

--- Quote from: aus9 on August 07, 2018, 11:16:31 PM ---Possible bug for checking of tce.installed using 64 bit submitqc
...


--- Quote ---unsquashfs test.tcz
ls -al squashfs-root/usr/local/tce.installed/
--- End quote ---

What I get

--- Code: ---unsquashfs test.tcz
Parallel unsquashfs: Using 4 processors
1 inodes (0 blocks) to write



created 1 files
created 4 directories
created 0 symlinks
created 0 devices
created 0 fifos
root@box:/tmp# ls -al squashfs-root/usr/local/tce.installed/
total 0
drwxrwxr-x 2 root staff 60 Aug  8 14:06 .
drwxr-xr-x 3 root root  60 Aug  8 14:06 ..
-rwxr-xr-x 1 tc   staff  0 Aug  8 14:06 test
--- End code ---

according to the wiki and the forum post for submissions.....that dir and script  is supposed to be
root:staff
775

thanks for reading

I sent a pm to the current maintainer  dentonlt but he has not been active for a long time
and its been more than one week since pm sent

IMHO the dir is fine but the script is wrong?

--- End quote ---

I haven't spoken to dentonit lately but I guess I'll take a look at this in the meantime..

To my knowledge directory permissions should be 775 root:staff
iirc the only requirement for the install script is that it's executable.

does your install script not run?

coreplayer2:
As pointed out by gutmensch in this post http://forum.tinycorelinux.net/index.php/topic,14988.msg85727.html#msg85727, tce.installed directory has a special tc use which requires 775 & root:staff. 






coreplayer2:
aus9  rather than unpacking the extension, why not load the extension and then verify ownership of the startup file?

I'll check the corepure64 permissions later but in tinycore ownership of the startup file appears inherited or set during the boot process regardless of assigned ownership during creation.

Navigation

[0] Message Index

[#] Next page

Go to full version