WelcomeWelcome | FAQFAQ | DownloadsDownloads | WikiWiki

Author Topic: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link  (Read 1952 times)

Offline AbNoRMiS

  • Hero Member
  • *****
  • Posts: 551
  • nothing can be impeccable in this imperfect world
    • @ß№®M!$
if install a scm in which /apps/scm_name/share/pixmaps/scm_name.png is a link to real png
and then uninstall this scm, then scm icon stays in the wbar and record about it stays in /usr/local/tce.icons :o
if after this install or uninstall another scm then the wbar dies and attempt to restart his leads to error
Quote
tc@box:~$ wbar &
tc@box:~$ Using /home/tc/.wbar config file.
 -> Image not found. Maybe using a relative path?

[1]+  Done                       wbar
tc@box:~$
wbar starts if installing this ill-fated scm again but then will show the second icon  :o :o and so on :o :o :o
it was in tcl 4.3 and also is in tcl 4.4rc1
Basic Design Concept © @ß№®M!$
please forgive my terrible english :)

Offline roberts

  • Administrator
  • Hero Member
  • *****
  • Posts: 7361
  • Founder Emeritus
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #1 on: February 26, 2012, 10:03:05 PM »
It would be helpful to specifically name them so that they can become "self contained".
10+ Years Contributing to Linux Open Source Projects.

Offline Jason W

  • Administrator
  • Hero Member
  • *****
  • Posts: 9520
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #2 on: February 27, 2012, 07:52:42 AM »
There are no scm's that intentionally contain a pixmaps/*.png file that is a link to something outside the same extension, to do so would not even make sense and if any exist it is an oversight in the process of using a set of tcz's to make and scm and will be corrected.

The only links purposefully made to anything outside of an extension is the /usr/local/lib/mozilla/plugins/flashplugin.so that is referenced by the flash.scm created by getFlash11.scm.    As well as the share/locale directory of a few that have many megabytes of locale data that exists in a separate scm to save bandwidth and space.   I think those are logical uses of a symlink to something existing outside of an scm and there is no harm done when those targets don't exist.  But as always I am open to other approaches.


Offline AbNoRMiS

  • Hero Member
  • *****
  • Posts: 551
  • nothing can be impeccable in this imperfect world
    • @ß№®M!$
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #3 on: February 27, 2012, 08:22:35 AM »
link to icon inside the same scm
something like
/apps/scm_name/share/pixmaps/scm_name.png -> /apps/scm_name/share/icons/hicolor/48x48/apps/application_name.png
Basic Design Concept © @ß№®M!$
please forgive my terrible english :)

Offline roberts

  • Administrator
  • Hero Member
  • *****
  • Posts: 7361
  • Founder Emeritus
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #4 on: February 27, 2012, 08:38:28 AM »
When most work as expected and a few do not. Then that would suggest to adjust the few that don't.
Besides the minimal size increase compared to the overall size increase of an scm is trivial.
tczs are not removal so their structure should not become the model for one that is intended to be removal.
10+ Years Contributing to Linux Open Source Projects.

Offline Jason W

  • Administrator
  • Hero Member
  • *****
  • Posts: 9520
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #5 on: February 27, 2012, 11:51:12 AM »
This morning was the first knowledge I had that a .png file existing as a link to an icon in the same extension was an issue, and they will be fixed at my first opportunity which is tonight.  Upstream apps are often known to use symlinks in their default make install for the same file needing to exist in 2 different places, perhaps that is where one or some instances came from as I normally copy when needing to add an icon.   Or perhaps the icon somewhere in the /apps/extension/share/icons/ directory was used, where they are symlinked icons as well and is often pointed to by XFullIconPath.  But since it is now a known issue, the pixmaps/*.png entries will be double checked to exist as a real file. 

Offline Jason W

  • Administrator
  • Hero Member
  • *****
  • Posts: 9520
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #6 on: February 27, 2012, 06:18:32 PM »
After testing all existing scms, I found the lone offender that used a symlink for a .png - opera-11.scm.  It is now fixed. 

Offline AbNoRMiS

  • Hero Member
  • *****
  • Posts: 551
  • nothing can be impeccable in this imperfect world
    • @ß№®M!$
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #7 on: February 27, 2012, 06:49:58 PM »
sorry, end up i don't understand
it will be fixed in the scripts that manage scms?
or when creating your scm will need to monitor and correct this point?
Basic Design Concept © @ß№®M!$
please forgive my terrible english :)

Offline Jason W

  • Administrator
  • Hero Member
  • *****
  • Posts: 9520
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #8 on: February 27, 2012, 07:02:50 PM »
When creating an scm, make sure that the "/apps/extension/pixmaps/extension.png"  is a real file and not a symlink to a file, as indicated by the initial claim of error.  Which extension showed this error anyway?

Offline AbNoRMiS

  • Hero Member
  • *****
  • Posts: 551
  • nothing can be impeccable in this imperfect world
    • @ß№®M!$
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #9 on: February 27, 2012, 07:11:02 PM »
i asked because i ran into this problem when creating scm
Basic Design Concept © @ß№®M!$
please forgive my terrible english :)

Offline Jason W

  • Administrator
  • Hero Member
  • *****
  • Posts: 9520
Re: wbar is broken if /apps/scm_name/share/pixmaps/scm_name.png is a link
« Reply #10 on: February 27, 2012, 07:25:47 PM »
Ok, thanks for the info, as since it affects the loading/unloading it is helpful to know.

And I am glad someone else is also interested in making scm's.