Tiny Core Linux

Tiny Core Extensions => TCE Bugs => Topic started by: mat128 on May 10, 2016, 09:40:05 AM

Title: gdisk pulls in ICU unnecessarily
Post by: mat128 on May 10, 2016, 09:40:05 AM

gdisk pulls in ICU
http://distro.ibiblio.org/tinycorelinux/6.x/x86_64/tcz/gdisk.tcz.dep

and patches the Makefile so that ICU is compiled in:
http://tinycorelinux.net/6.x/x86_64/tcz/src/gdisk/gptfdisk-1.0.0-convenience-1.patch

Since 0.8.9, icu is not required by gdisk anymore: "Removed dependency on libicu for UTF-16 support."
https://sourceforge.net/u/guikcd93/gptfdisk/ci/946866e68b12d345e1f60681d57b93ece0ae8b7e/tree/NEWS

This bloats images needing gdisk unnecessarily.

Short of rebuilding the packages on our own, would it be possible for this to be removed?

Title: Re: gdisk pulls in ICU unnecessarily
Post by: Juanito on May 10, 2016, 10:31:48 AM

I guess it depends on whether you require unicode characters in the partition names or not?

Title: Re: gdisk pulls in ICU unnecessarily
Post by: mat128 on May 10, 2016, 11:30:19 AM

Quote

Removed dependency on libicu for UTF-16 support.

I was reading this more like "libicu is not required anymore for UTF-16 support".

From https://sourceforge.net/p/gptfdisk/code/ci/master/tree/README

Quote

* The ICU library (http://site.icu-project.org), which provides support for
  Unicode partition names, is optional on all platforms except Windows, on
  which it's not supported. Using this library was required to get proper
  UTF-16 partition name support in GPT fdisk versions prior to 0.8.9, but
  as of that version it should not longer be required. Nonetheless, you can
  use it if you're having problems with the new UTF-16 support. This
  library is normally installed in Linux and OS X, but you may need to
  install the development headers (libicu-dev or something similar in
  Linux; or the libicu36-dev Fink package in OS X). To compile with ICU
  support, you must modify the Makefile: Look for commented-out lines that
  refer to USE_UTF16, -licuuc, -licudata, or -licucore. Uncomment them and
  comment out the equivalents that lack these lines.

The project's readme seems to agree with my understanding, the new UTF-16 support seems to have been integrated in 0.8.9.

Any chance we get rid of libicu and switch to the built-in UTF-16 support?

Title: Re: gdisk pulls in ICU unnecessarily
Post by: Juanito on May 10, 2016, 11:34:00 AM

I'll have a look tomorrow.

Title: Re: gdisk pulls in ICU unnecessarily
Post by: Juanito on May 11, 2016, 02:21:07 AM

updated gdisk posted

Title: Re: gdisk pulls in ICU unnecessarily
Post by: mat128 on May 12, 2016, 11:01:56 AM

Thank you so much! Very quick lead time, much appreciated.